Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The color contrast for the red and green lines that indicate code changes in the Monaco diff editor is low #4750

Open
1 of 2 tasks
clamli opened this issue Nov 13, 2024 · 0 comments
Labels
accessibility bug Issue identified by VS Code Team member as probable bug diff-editor

Comments

@clamli
Copy link

clamli commented Nov 13, 2024

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Link

https://microsoft.github.io/monaco-editor/

Monaco Editor Playground Code

Reproduction Steps

The color contrast for the red and green lines that indicate code changes in the Monaco diff editor is low.

https://microsoft.github.io/monaco-editor/

Image

Red line:

Foreground element: #FFA9A4
Background or adjacent element: White background #FFFFFF
Contrast Ratio: 1.8:1

Green line:

Foreground element: #CEE59E
Background or adjacent element: White background #FFFFFF
Contrast Ratio: 1.3:1

1.4.11 Non-text Contrast (AA) (opens in new window) suggests the contrast ratio to be at least 3:1.

Question:

  1. Can we modify these colors within the Monaco code?
  2. If we are not allowed to modify it in Monaco code, can we override color settings from our side?

Actual (Problematic) Behavior

No response

Expected Behavior

No response

Additional Context

No response

@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug accessibility diff-editor labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug Issue identified by VS Code Team member as probable bug diff-editor
Projects
None yet
Development

No branches or pull requests

2 participants