Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Incorrect nullability metadata for StackTraceCollector #1039

Open
cgranade opened this issue Jun 9, 2022 · 0 comments
Open

Incorrect nullability metadata for StackTraceCollector #1039

cgranade opened this issue Jun 9, 2022 · 0 comments
Labels
bug Something isn't working maintenance Improve codebase quality

Comments

@cgranade
Copy link
Contributor

cgranade commented Jun 9, 2022

Describe the bug

The Microsoft.Quantum.Simulation.Common.StackTraceCollector class contains incorrect nullability metadata that can cause null reference exceptions in code that depends on stack traces in the simulation runtime. For example, the public StackTraceCollector.CallStack property can be null if StackTraceCollector.hasFailed is false; that null can propagate out via the OnException event, causing its nullability metadata to be incorrect as well.
@cgranade cgranade added bug Something isn't working needs triage An initial review by a maintainer is needed labels Jun 9, 2022
@bettinaheim bettinaheim added maintenance Improve codebase quality and removed needs triage An initial review by a maintainer is needed labels Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working maintenance Improve codebase quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cgranade @bettinaheim