New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript generation needs to "escape" keywords #116

Open

dunhor opened this issue Aug 20, 2021 · 1 comment

Labels

Member

dunhor commented Aug 20, 2021

E.g. the following error exists:

windows/WinRTTurboModule/Generated Files/types/Windows.Devices.Custom.d.ts:55:48 - error TS1138: Parameter declaration expected.

55         public constructor(deviceType: number, function: number, accessMode: Windows.Devices.Custom.IOControlAccessMode, bufferingMethod: Windows.Devices.Custom.IOControlBufferingMethod);
                                                  ~~~~~~~~

The text was updated successfully, but these errors were encountered:

dunhor added bug typescript labels

Member Author

dunhor commented Aug 20, 2021

Helpful list: microsoft/TypeScript#2536

To be fair, we probably don't do this with C++ (though I'm not entirely sure you can get valid idl that way?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment