New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PAL capable of producing back traces. #89

Open

mjp41 opened this issue Aug 14, 2019 · 1 comment

Member

mjp41 commented Aug 14, 2019

In #88, we implemented enough backtrace to flush out some CI failures for Windows. This should be refactored.

We should always call Pal::error instead of abort.
Assert should be refactored to call Pal::error in the failure case.
In some configurations Pal::error should produce a backtrace.
The Pal on Windows should account for running in headless CI, and stop generating dialog boxes.

mjp41 mentioned this issue

CI testing help #88

Merged

Member Author

mjp41 commented Apr 3, 2020

#161 this contributes to addressing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment