-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: When "Open Workspace from File" eslint complains that it cannot find imports, when "Open from Folder" the same code, no issues #1847
Comments
To my knowledge typescript eslint doesn't support glob patterns for projects. If you think they should be supported please file an issue against the typescript eslint repository. |
that's the thing, it only works with the globs, but that feels like a hack. Maybe I wasn't clear, the first case doesn't work, the second case does. |
the specific error it gives is that if I use "Open Workspace from File" with the relative paths config linked in the issue, then entering any of the JS or TS files in the monorepo gives this error:
Even |
Sorry, I misunderstood the issue. This is really strange since I use relative paths all over my repositories. See https://github.com/microsoft/vscode-eslint/blob/dbaeumer/stale-cuckoo-gold/client/.eslintrc.json#L1 Can you please provide me with a GitHub repository I can clone with a minimal setup that repros what you are seeing. |
No worries about the misunderstanding 🙂 I didn't phrase it particularly well, so it was easy to get confused my only thought, maybe it's that we include the root folder in there, which includes all the other workspaces, I'm going to see locally if that's true then if it's still an issue I'll get you a minimal setup edit: seems to not have an effect, I'll get you a repro repo |
Bit of an odd error, seems to be related to if the .eslintrc has a
parserOptions.project
, as when I change fromBROKEN
.eslintrc with relative paths
folders renamed but same structure
WORKS
.eslintrc with glob path
folders renamed but same structure
vscode Workspace file
repo-name.code-workspace file
folders renamed but same structureThe text was updated successfully, but these errors were encountered: