You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Verbose output log from "Language Support for Java": log.txt
Current Result
The debug session starts with no arguments.
Expected Result
The debug session should not start, because it was cancelled.
Additional Informations
The implementation of SpecifyProgramArgs is at extension.ts:185. When the user cancels, the function returns a string with a single space. That's indistinguishable from the user entering a space in the input.
I presume that throwing some sort of cancellation exception would be good here, for instance throw new Error('Launch cancelled'). It would be even better if the exception didn't display an error box, but I don't know enough about vscode extension command handlers to know if that's possible.
Alternatively you could just remove the "or 'Escape' to cancel" hint in the input popup.
The text was updated successfully, but these errors were encountered:
When launching a Java program with
${command:SpecifyProgramArgs}
, the popup says that I can press 'Escape' to cancel, but it runs anyway.Environment
Steps To Reproduce
Test.java
and pressF5
.See repo above, but you only need these two files:
Test.java
:.vscode/launch.json
:Verbose output log from "Language Support for Java": log.txt
Current Result
The debug session starts with no arguments.
Expected Result
The debug session should not start, because it was cancelled.
Additional Informations
The implementation of
SpecifyProgramArgs
is at extension.ts:185. When the user cancels, the function returns a string with a single space. That's indistinguishable from the user entering a space in the input.I presume that throwing some sort of cancellation exception would be good here, for instance
throw new Error('Launch cancelled')
. It would be even better if the exception didn't display an error box, but I don't know enough about vscode extension command handlers to know if that's possible.Alternatively you could just remove the "or 'Escape' to cancel" hint in the input popup.
The text was updated successfully, but these errors were encountered: