Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New > Java Class" wizard cannot create a class for Japanese identifiers. #789

Open
jdneo opened this issue Sep 26, 2023 · 1 comment
Open
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jdneo
Copy link
Member

jdneo commented Sep 26, 2023

Originally reported from redhat-developer/vscode-java#3289

When I open the "New > Java Class" wizard and enter a Japanese class name, I receive the message "Invalid Java qualified name." and I am unable to create a Java class.

Environment
  • Operating System: Windows 11
  • JDK version: 17
  • Visual Studio Code version: 1.79.2
  • Java extension version: v0.25.14
Steps To Reproduce
  1. Select any package, right-click, and choose "New > Java Class."
  2. Enter Japanese characters as the class name. For example, "ほげ"
Current Result

It displays "Invalid Java qualified name."

Expected Result

The class is generated.

Additional Informations

In Java, we can use characters from languages such as Japanese and others in identifiers.

https://docs.oracle.com/javase/specs/jls/se17/html/jls-3.html#jls-3.8

@jdneo
Copy link
Member Author

jdneo commented Sep 26, 2023

Root cause is here:

export function isJavaIdentifier(identifier: string): boolean {

@jdneo jdneo added the bug Something isn't working label Oct 31, 2023
@jdneo jdneo added the help wanted Extra attention is needed label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant