Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky testing framework discovery against actual python process tests #11634

Closed
karrtikr opened this issue May 6, 2020 · 2 comments
Closed
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on

Comments

@karrtikr
Copy link

karrtikr commented May 6, 2020

The following test with unittest framework often fails on CI both in Azdo as well as in GHA

  1) Unit Tests - unittest - discovery against actual python process
       Re-run failed tests results in the correct number of tests counted:

      AssertionError [ERR_ASSERTION]: This test was written assuming there was 2 tests run that would fail. (iteration 1)
      + expected - actual

      -0
      +2

Example builds:

Another flaky test under the same suite,

  1) Unit Tests - unittest - discovery against actual python process
       Ensure correct test count for running a set of tests multiple times:

      AssertionError [ERR_ASSERTION]: This test was written assuming there was 2 tests run that would fail. (iteration 1)
      + expected - actual

      -0
      +2

Example build:

It maybe the case that the operation itself is flaky (due to use of sockets in unittest framework), and the tests are just reflecting that. If that's the case, these should be fixed by #10119.

I think also recall seeing this failing with other frameworks - pytest, nose before, but I am not sure as they don't fail anymore, so just focusing on the unittest framework for now.

cc @karthiknadig

@karrtikr karrtikr added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. triage-needed Needs assignment to the proper sub-team area-internal Label for non-user facing issues labels May 6, 2020
@karthiknadig karthiknadig removed the triage-needed Needs assignment to the proper sub-team label May 6, 2020
@karrtikr karrtikr changed the title Fix Flaky testing framework discovery against actual python process test Fix Flaky testing framework discovery against actual python process tests May 8, 2020
@github-actions github-actions bot removed the needs PR label Aug 9, 2022
@karrtikr karrtikr added the needs PR Ready to be worked on label Aug 9, 2022
@eleanorjboyd
Copy link
Member

@karthiknadig do you have context for this? Does this problem still exist? The links no longer work and if it is talking about our product of python tests the rewrite made most things different so it might not be applicable.

@karthiknadig
Copy link
Member

This was bout the old test code. This can be closed.

@karthiknadig karthiknadig closed this as not planned Won't fix, can't repro, duplicate, stale Jul 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

3 participants