Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor our pytest unit tests #12416

Closed
kimadeline opened this issue Jun 17, 2020 · 1 comment
Closed

Refactor our pytest unit tests #12416

kimadeline opened this issue Jun 17, 2020 · 1 comment
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on

Comments

@kimadeline
Copy link

kimadeline commented Jun 17, 2020 •
edited
Loading

The tests in tests/testing_tools/adapter/test_functional.py compare the output of running pytest test discovery against a (rather long) hardcoded list of nodes. Not only is difficult to debug, but it also makes the tests brittle (see when the Windows behaviour changed and we ended with a CI failure: #12372). We should refactor these tests in a way that is not dependent on pytest's output.

💡 We should probably refactor our Python unit tests in general, and not just these ones.
@kimadeline kimadeline added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. triage-needed Needs assignment to the proper sub-team area-internal Label for non-user facing issues labels Jun 17, 2020
@kimadeline kimadeline mentioned this issue Jun 18, 2020
Merged
10 tasks
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jun 18, 2020
@kimadeline kimadeline mentioned this issue Feb 4, 2022
Merged
@github-actions github-actions bot removed the needs PR label Aug 9, 2022
@karrtikr karrtikr added the needs PR Ready to be worked on label Aug 9, 2022
@eleanorjboyd
Copy link
Member

closing in favor of this meta issue: #17242

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karrtikr @eleanorjboyd @kimadeline