Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error reporting should be smoother #17101

Closed
isidorn opened this issue Aug 24, 2021 · 5 comments
Closed

Error reporting should be smoother #17101

isidorn opened this issue Aug 24, 2021 · 5 comments
Assignees
Labels
area-testing bug Issue identified by VS Code Team member as probable bug partner ask

Comments

@isidorn
Copy link

isidorn commented Aug 24, 2021

Testing #17040

  1. Have some error in your test file
  2. Notice the error

I see the following problems:

  1. We are piggy backing on the test infrastructure and vscode thinks this is just another test directory. Which is incorrect, thus the hover information is off and VS Code offers commands to Run All tests
  2. Clicking on the error does not take you to Python / Output
  3. Should we introduce some infrastructure for error reporting, or do we maybe already have something @connor4312

Screenshot 2021-08-24 at 13 50 17

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Aug 24, 2021
@connor4312
Copy link
Member

The markdown supports command links, could that be used to show error details here?

@karthiknadig karthiknadig added area-testing bug Issue identified by VS Code Team member as probable bug triage partner ask and removed triage-needed Needs assignment to the proper sub-team labels Aug 24, 2021
@karthiknadig
Copy link
Member

If you hover on that item you should see the full error details. But I think if we can get a output channel (just like for runs) to report discovery issues that would be great. Since there is already a "Show Output", I think having a way to add discovery errors to that should help with reporting these. /cc @connor4312

Previously we had a custom logging channel that captured both the discovery and run output. Now those two are separated, because there is a way to capture run output for each run.

@connor4312
Copy link
Member

It seems like the error is pretty large and textual, maybe it should be written and opened in the editor from a temp file (or custom TextDocumentContentProvider)?

@karthiknadig
Copy link
Member

If users close it accidentally, that error will be lost right? I feel like it needs to be in the logs. Just need to isolate it from the rest of the python logs. Otherwise it might be to difficult to find the issue.

/cc @luabud

@karthiknadig karthiknadig added needs proposal Need to make some design decisions and removed triage labels Aug 30, 2021
@karthiknadig karthiknadig removed their assignment Aug 30, 2021
@eleanorjboyd eleanorjboyd self-assigned this Dec 4, 2023
@eleanorjboyd
Copy link
Member

we have completed item 2, there is a potential Connor and I might discuss better error reporting but I think for now im going to close this issue since it is stale (pre python testing rewrite), and will move to the updated conversation happening here: #22154

@eleanorjboyd eleanorjboyd closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2023
@github-actions github-actions bot removed the needs proposal Need to make some design decisions label Dec 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing bug Issue identified by VS Code Team member as probable bug partner ask
Projects
None yet
Development

No branches or pull requests

4 participants