Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart send setting id is inconsistent with other setting ids #22556

Open
mjbvz opened this issue Nov 28, 2023 · 0 comments
Open

Smart send setting id is inconsistent with other setting ids #22556

mjbvz opened this issue Nov 28, 2023 · 0 comments
Assignees
@anthonykim1
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. triage-needed Needs assignment to the proper sub-team

Comments

@mjbvz
Copy link

mjbvz commented Nov 28, 2023

Testing #22536

Current name: python.REPL.enableREPLSmartSend

However most other python settings use names like python.diagnostics.sourceMapsEnabled

Personally I prefer: python.REPL.smartSend.enabled as this will let you add other scoped smart send settings in the future
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 28, 2023
@anthonykim1 anthonykim1 added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthonykim1 anthonykim1

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. triage-needed Needs assignment to the proper sub-team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjbvz @anthonykim1