Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventHandlers content should have js coloring #16628

Closed
isidorn opened this issue Dec 6, 2016 · 3 comments
Closed

EventHandlers content should have js coloring #16628

isidorn opened this issue Dec 6, 2016 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality html HTML support issues
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Dec 6, 2016

Refs #16526

Event handler values should have javascript coloring. Currently it is colored as a string but all the js funcitonality is there. As a user would not expect this to work due to string coloring - thus it will be hard to find the nice intelli-sense support you have there

screen shot 2016-12-06 at 12 14 35

@isidorn isidorn added the html HTML support issues label Dec 6, 2016
@aeschli
Copy link
Contributor

aeschli commented Dec 6, 2016

Not easy to implement as this would drag in a whole JavaScript grammar. But not the original one, but one that uses HTML escaping rules.

@aeschli aeschli added the feature-request Request for new features or functionality label Dec 6, 2016
@aeschli aeschli added this to the Backlog milestone Dec 6, 2016
@aeschli
Copy link
Contributor

aeschli commented Dec 7, 2016

Would have to go into the textmate grammar we use (https://github.com/textmate/html.tmbundle)

@aeschli
Copy link
Contributor

aeschli commented Feb 7, 2017

This issue was moved to textmate/html.tmbundle#50

@aeschli aeschli closed this as completed Feb 7, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality html HTML support issues
Projects
None yet
Development

No branches or pull requests

2 participants