Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected confirmation after switching auth account preference #231961

Closed
bamurtaugh opened this issue Oct 22, 2024 · 1 comment
Closed

Expected confirmation after switching auth account preference #231961

bamurtaugh opened this issue Oct 22, 2024 · 1 comment
Assignees

Comments

@bamurtaugh
Copy link
Member

bamurtaugh commented Oct 22, 2024

Testing #229420, #231880

Version: 1.95.0-insider (user setup)
Commit: 804f450ca900d24db25e7174e8b6dfb3fb2a318c
Date: 2024-10-22T13:30:10.100Z
Electron: 32.2.1
ElectronBuildId: 10427718
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.26120

I switched preferred accounts for GH Copilot, which worked successfully. Just thinking out loud, I think I expected some sort of toast confirmation in VS Code that my account preference took effect, maybe with a CTA to check it out and confirm.

@TylerLeonhardt
Copy link
Member

Given this is a low stakes operation, I don't think VS Code core needs to provide anything here. Whether an extension would like to react to the event that they get when their preference changes is a different story. The main one this was built for, Copilot, already reacts to this so I think we're good here for now. If we get more feedback, I'm happy to open this up again. Thanks for the suggestion!

@TylerLeonhardt TylerLeonhardt closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants