Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

larger HTML with mixed JS mode forces all after to be JS #72010

Closed
tomByrer opened this issue Apr 9, 2019 · 3 comments
Closed

larger HTML with mixed JS mode forces all after to be JS #72010

tomByrer opened this issue Apr 9, 2019 · 3 comments
Assignees
Labels
html HTML support issues

Comments

@tomByrer
Copy link

tomByrer commented Apr 9, 2019

Version: 1.33.0 (system setup)
Commit: 0dd516d
Date: 2019-04-04T15:14:28.026Z
OS: Windows_NT x64 10.0.17134

Steps to Reproduce:

  1. Open larger HTML file that includes <script></script> tags
  2. Use Inspect TM selectors
  3. Inspect HTML code after a </script>, & the reported (& visually highlighted) code is JavaScript, but should be HTML.

Does this issue occur when all extensions are disabled?: Yes

Thanks for all your hard work! :)

@vscodebot vscodebot bot added the html HTML support issues label Apr 9, 2019
@aeschli
Copy link
Contributor

aeschli commented Apr 10, 2019

Is this a dup of #70614

Please add the source sample..

@aeschli aeschli self-assigned this Apr 10, 2019
@tomByrer
Copy link
Author

Not sure if related.

Any Save As... YouTube HTML page will work it seems. Can't test too much with these files, since VSCode lags out sometimes. (Perhaps related or another bug?)

If you /really/ want me to attach / link a file, I can.

@aeschli
Copy link
Contributor

aeschli commented Apr 23, 2019

Thanks for the tip, I can reproduce with the youtube html page.

Yes, the embedded JavaScript code isn't correctly understood by the grammar and prevents the rest
of the page to be correctly highlighted: Dup of #20488

@aeschli aeschli closed this as completed Apr 23, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
html HTML support issues
Projects
None yet
Development

No branches or pull requests

2 participants