Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppsAndFeaturesEntries added by default map fields unneccesarily #576

Closed
Trenly opened this issue Jan 2, 2025 · 3 comments
Closed

AppsAndFeaturesEntries added by default map fields unneccesarily #576

Trenly opened this issue Jan 2, 2025 · 3 comments

Comments

@Trenly
Copy link
Contributor

Trenly commented Jan 2, 2025

Brief description of your issue

When parsing an MSI, AppsAndFeaturesEntries are added automatically. However, fields that should be left out under certain conditions are included contrary to the advice the community has received in the past.

DisplayVersion is included even when it is the same as PackageVersion -> The community has been told this is bad as it creates a version range mapping unnecessarily
DisplayName is included even when it is the same as PackageName
Publisher is included even when it matches the Publisher in the defaultLocale manifest

Steps to reproduce

wingetcreate new with any MSI package

Expected behavior

DisplayVersion would only be included if it does not match PackageVersion

Actual behavior

Unnecessary fields are included

Environment

PS E:\winget-pkgs> wingetcreate info
Windows Package Manager Manifest Creator v1.9.3.0
Copyright (c) Microsoft Corporation. All rights reserved.

Operating System: Microsoft Windows NT 10.0.26100.0
System Architecture: X64

Winget-Create Directories  Path
------------------------------------------------------------------------------------------------------------------------------------------
Logs                       %LOCALAPPDATA%\Packages\Microsoft.WindowsPackageManagerManifestCreator_8wekyb3d8bbwe\LocalState\DiagOutputDir
User settings              %LOCALAPPDATA%\Packages\Microsoft.WindowsPackageManagerManifestCreator_8wekyb3d8bbwe\LocalState\settings.json
Installer cache            %TEMP%\wingetcreate
@Trenly
Copy link
Contributor Author

Trenly commented Jan 2, 2025

@vedantmgoyal9 - I belive you introduced this in #550

@mdanish-kh - Does #575 fully address this, or will DisplayVersion still be added when updating a manifest? I believe that the flow should only update properties of AppsAndFeaturesEntries that are currently present, and not add any that are not present

@mdanish-kh
Copy link
Contributor

I believe that the flow should only update properties of AppsAndFeaturesEntries that are currently present, and not add any that are not present

@Trenly - That's exactly how the current update flow plays out. The change in #550 probably unintentionally affected the NewCommand flow, which should be fixed in #575

@Trenly
Copy link
Contributor Author

Trenly commented Jan 2, 2025

I'll presume #575 fixed this

@Trenly Trenly closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants