Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24 implement active peers snapshots #28

Merged
merged 6 commits into from
Jul 30, 2024

Conversation

yuliannabn
Copy link
Collaborator

Task

Implement active peer snapshots: periodically save all active peers with timestamp.

Changes

  • Added an active_peers table to the database (version 5)
  • Added a --snapshot-interval -si flag for specifying how often snapshots are taken
  • Current active peers are retrieved and persisted into active_peers at every snapshotInterval
  • Changed format for --conn-timeout -ct from int to time string (e.g. "12h"), same as --snapshot-interval

snapshot-interval defines how often active_peers get a snapshot
for better readability, connection-timeout will be set from a string, not a number. For example, "10s"
@yuliannabn yuliannabn requested a review from santi1234567 July 30, 2024 20:24
@yuliannabn yuliannabn self-assigned this Jul 30, 2024
@yuliannabn yuliannabn linked an issue Jul 30, 2024 that may be closed by this pull request
Copy link
Member

@santi1234567 santi1234567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@yuliannabn yuliannabn merged commit 0d5b397 into main Jul 30, 2024
@santi1234567 santi1234567 deleted the 24-implement-active-peers-snapshots branch July 31, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement active peers snapshots
2 participants