Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tune deprecation system #33

Merged
merged 7 commits into from
Aug 13, 2024
Merged

Tune deprecation system #33

merged 7 commits into from
Aug 13, 2024

Conversation

yuliannabn
Copy link
Collaborator

Changes

  • Add unit tests for ParseConnError
  • Fix bug when parsing connection errors, which would previously be parsed at random (used ContainsAny instead of Contains)
  • Added 4 new known error types (ErrorIOTimeout, ErrorNoRouteToHost, ErrorProtocolNegotiation, ErrorBadHandshakeDisconnect)
  • Deprecation margin increased from 3 to 48 hours

@yuliannabn yuliannabn self-assigned this Aug 12, 2024
@yuliannabn yuliannabn linked an issue Aug 12, 2024 that may be closed by this pull request
Tune deprecation system #31
Closed
santi1234567
santi1234567 requested changes Aug 12, 2024
View reviewed changes
crawler/peering.go Outdated Show resolved Hide resolved
@yuliannabn yuliannabn merged commit 50d2bc0 into main Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santi1234567 santi1234567 santi1234567 requested changes

Assignees

@yuliannabn yuliannabn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tune deprecation system
2 participants
@yuliannabn @santi1234567