Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to pick files or directory? #1105

Open
BirjuVachhani opened this issue Aug 31, 2022 · 12 comments
Open

How to pick files or directory? #1105

BirjuVachhani opened this issue Aug 31, 2022 · 12 comments
Assignees
Labels
desktop The issue applies to Windows, Linux or MacOS implementations. macos

Comments

@BirjuVachhani
Copy link

I know we can use pickFiles() to open file picker and getDirectoryPath() to choose a directory but my use case allows user to select files or directory or both at the same time. How can I achieve this with this plugin?

For example, I also implemented drag and drop files support using desktop_drop package which supports both files and directory dropping. So when I drop things, it gives me List<XFile> where can contain directories if I have selected any. I can't do this with this plugin. A lot of native apps does this.

I have tested this on MacOS. pickFiles() doesn't allow selecting directories too. Only files.

I'd like to allow both at the same time. Can you please help?

@BirjuVachhani BirjuVachhani added the new issue An issue that hasn't yet been seen from the maintainer label Aug 31, 2022
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Sep 8, 2022
@BirjuVachhani
Copy link
Author

Any updates?

@github-actions github-actions bot removed the stale label Sep 9, 2022
@miguelpruivo
Copy link
Owner

Which platform are you trying this on?

@miguelpruivo miguelpruivo added triage Further information is requested and removed new issue An issue that hasn't yet been seen from the maintainer labels Sep 15, 2022
@au2001
Copy link

au2001 commented Sep 19, 2022

@miguelpruivo I have the same use-case as OP and can confirm that exactly what they described happens when using macOS (Monterey 12.6).

With pickFiles, when highlighting a directory and clicking Choose, the directory is simply opened as if I had double-clicked it, rather than being returned.
With getDirectoryPath, all files are grayed out and thus cannot be selected. Also, it is not possible to select multiple folders at once.

@github-actions
Copy link

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Sep 27, 2022
@miguelpruivo miguelpruivo added desktop The issue applies to Windows, Linux or MacOS implementations. and removed stale labels Sep 27, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Oct 6, 2022
@github-actions
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale.

@au2001
Copy link

au2001 commented Oct 20, 2022

up

@Aunali321
Copy link

@miguelpruivo can you reopen this issue?

@bobmoff
Copy link

bobmoff commented Nov 22, 2022

This was immediately the first thing i realized was missing. Need a way to select a mixture of multiple files and folders in the same picker window. The native picker on macOS has support for this at least.

Without this feature, opening av picker becomes a much worse experience, compared to drag and drop. But some people are not tech savvy enough to perform a drop and drop, especially not on a small laptop where cmd+tab needs to be involved at the same time when dragging.

🤞🏻

@stephane-archer
Copy link
Collaborator

Screenshot 2024-11-13 at 16 31 52

On MacOS with this plugin, it's impossible to select files and folders at the same time @miguelpruivo

@github-actions github-actions bot removed the stale label Feb 18, 2025
Repository owner deleted a comment from BirjuVachhani Feb 18, 2025
Repository owner deleted a comment from github-actions bot Feb 18, 2025
Repository owner deleted a comment from BirjuVachhani Feb 18, 2025
@stephane-archer stephane-archer removed the triage Further information is requested label Feb 18, 2025
@stephane-archer
Copy link
Collaborator

stephane-archer commented Feb 18, 2025

Now we can also address #1105 but that would require a public API change.

@orestesgaolin can we add a function for "selecting files and folders" implemented only in MacOS for now? That way we don't break the API, just add a function. What are your thoughts on this?

Also, do you know how to disable the closing bot on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop The issue applies to Windows, Linux or MacOS implementations. macos
Projects
None yet
Development

No branches or pull requests

7 participants