Can you fix the --on-start --on-stop options?

[mikebrady]

This is from abrasive#296 (comment):

Btw can you fix the --on-start --on-stop options?
with the commandline /usr/local/bin/shairport -d -a hostname --wait-cmd --on-start='/usr/local/bin/mpc -q stop' -- -d plughw:0,0 I get:
/usr/local/bin/shairport: invalid option -- 'q'
/usr/local/bin/shairport -d -a hostname --wait-cmd --on-start="/usr/local/bin/mpc -q stop" -- -d plughw:0,0 -- -d plughw:0,0 doesn't give the invalid option but doesn't work either. The same happens with /usr/local/bin/shairport -d -a hostname --wait-cmd --on-start='/usr/local/bin/mpc\ -q\ stop' -- -d plughw:0,0

It works with the official version, and also when I merged the on-start/stop/wait commit myself into shairport-sync 2.0. Of course I see why it doesn't work, and I could just make a script, but..

[mikebrady]

Would you be kind enough to let me have the merge, even if it's out of date? It'll probably save me a lot of time.

[mantheman]

Seems I just merged the -w / --wait-cmd option to the 2.0 code. So that means one of your later commits broke the parsing of (--on-start) probably. btw I get the "exec of external start command failed" even if it succeeds, but that also happens on the official one shairport. (I just make it quiet anyways)

http://pastebin.com/DXxnqaQM

[mikebrady]

Thanks. I changed the start/stop code quite a bit from 2.0, so the patch wasn't really applicable. However, I pushed an update which, I think, fixes the problem, and should not result in those bogus (?) error messages. Let me know.

[mantheman]

It works properly now. Also fixed the bogus error messages. Great!

[mikebrady]

Great.