Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support websocket compression #30

Open
casprack opened this issue Apr 26, 2018 · 2 comments
Open

Support websocket compression #30

casprack opened this issue Apr 26, 2018 · 2 comments

Comments

@casprack
Copy link

casprack commented Apr 26, 2018 •
edited
Loading

In index.js, perMessageDeflate is set to false (here). There's a accompanying comment indicating that this was because of a bug in websockets (here). This bug has been fixed and it would be great if compression was supported in this package, potentially even by default.

I did some testing in my environment and everything seems to work perfectly when compression is enabled, and delivers significant reductions in network traffic.
@mikemintz
Copy link
Owner

Good find! Would you mind submitting a PR enabling compression by default, and I can go ahead and bump a new version.

@shareefalis shareefalis mentioned this issue Apr 7, 2020
Merged
@shareefalis
Copy link
Contributor

Created a pull request. Can you go ahead and merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikemintz @shareefalis @casprack