From 4dd55f431cea80e514a6d13cf0ea77e8bf0cc52a Mon Sep 17 00:00:00 2001 From: Christopher Carter Date: Mon, 1 Apr 2013 11:41:39 +1200 Subject: [PATCH 1/2] Fixed broken "warning signs" list. --- README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index ab3636c..f96ab9f 100644 --- a/README.md +++ b/README.md @@ -128,7 +128,9 @@ Source: http://junit.sourceforge.net/doc/testinfected/testing.htm ### Flaw #3: Brittle Global State & Singletons #### Warning Signs * Adding or using singletons -* Adding or using static fields or static methods Adding or using static initialization blocks Adding or using registries +* Adding or using static fields or static methods +* Adding or using static initialization blocks +* Adding or using registries * Adding or using service locators ###Flaw #4: Class Does Too Much From 85041acf352278ea4742be3f47daec4939f59264 Mon Sep 17 00:00:00 2001 From: Christopher Carter Date: Mon, 1 Apr 2013 11:47:37 +1200 Subject: [PATCH 2/2] Fixed a second broken list. But it was the "Class does too much" one this time. --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index f96ab9f..f2c3f2e 100644 --- a/README.md +++ b/README.md @@ -137,7 +137,8 @@ Source: http://junit.sourceforge.net/doc/testinfected/testing.htm ####Warning Signs * Summing up what the class does includes the word “and” -* Class would be challenging for new team members to read and quickly “get it” Class has fields that are only used in some methods +* Class would be challenging for new team members to read and quickly “get it” +* Class has fields that are only used in some methods * Class has static methods that only operate on parameters Source: http://misko.hevery.com/code-reviewers-guide/