14-loading-state #25
Merged
14-loading-state #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #14
Considerations:
There needs to be a way for VotingHandler to check the progress of the effect, as currently it manages its own logic for the remaining duration. I believe it should get the remaining seconds from ChaosHandler / its currently running effect. At the moment as of this change, VotingHandler gets a reference to the current effect result of triggering the effect. It could use this reference to get aremaining_secondsvalue from it if we're not in an accepting votes period.^-- Logic to pause the current effect and have it carry over to VotingHandler's logic was added with this commit, however there may be some wonky-ness with this implementation. But it's much preferable to the previous implementation.
Unrelated, but I also think VotingHandler should be broken up into two classes. Currently it handles both the logic for voting as well as managing tasks. Perhaps a TaskHandler class should be defined.