Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milton Client not parsing WebDav response correctly - missing logic for set responses #64

Open
peteanusergiu opened this issue Aug 23, 2015 · 0 comments

Comments

@peteanusergiu
Copy link

For example when issuing a PROPFIND for property supported-report-set

<?xml version="1.0" encoding="UTF-8"?>
<D:propfind xmlns:D="DAV:"><D:prop><D:supported-report-set /></D:prop></D:propfind>

and receiving back:

<d:multistatus xmlns:cal="urn:ietf:params:xml:ns:caldav" xmlns:cs="http://calendarserver.org/ns/" xmlns:card="urn:ietf:params:xml:ns:carddav" xmlns:d="DAV:"><d:response><d:href>/spica-contacts/carddav/principals/StsConnectorMockUser/</d:href><d:propstat><d:prop><d:supported-report-set><d:supported-report><d:report><d:principal-search-property-set/></d:report></d:supported-report><d:supported-report><d:report><card:addressbook-query/></d:report></d:supported-report><d:supported-report><d:report><d:principal-property-search/></d:report></d:supported-report><d:supported-report><d:report><card:addressbook-multiget/></d:report></d:supported-report><d:supported-report><d:report><d:expand-property/></d:report></d:supported-report></d:supported-report-set></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response><d:response><d:href>/spica-contacts/carddav/principals/StsConnectorMockUser/addressBooks/</d:href><d:propstat><d:prop><d:supported-report-set><d:supported-report><d:report><d:principal-search-property-set/></d:report></d:supported-report><d:supported-report><d:report><card:addressbook-query/></d:report></d:supported-report><d:supported-report><d:report><d:principal-property-search/></d:report></d:supported-report><d:supported-report><d:report><card:addressbook-multiget/></d:report></d:supported-report><d:supported-report><d:report><d:expand-property/></d:report></d:supported-report></d:supported-report-set></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response></d:multistatus>

Milton client only deals with parent element : <d:supported-report-set>. No child of the parent is whatsoever discover. Corresponding response object will have a List with one PropResponse containing exact one property with value "".

See PropFindResponse > getFoundProps() and PropFindResponse() expects collections only for d:prop and not for direct children of d:prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant