Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues in the CONTRIBUTING.md #111

Open
SuperSupeng opened this issue Mar 4, 2022 · 2 comments
Open

Some issues in the CONTRIBUTING.md #111

SuperSupeng opened this issue Mar 4, 2022 · 2 comments
Assignees

Comments

@SuperSupeng
Copy link

In the file CONTRIBUTING.md "What contributions can I make?" section.

  • "please comment on the issue to notify the team." What content should we comment on, where can we find it, or is it better to use the issue label?
  • "Describe the intended feature and discuss the design and implementation with the team and community. Once the team agrees on the plan, you can follow the Contributing code to implement it." If I understand the current process correctly. I think if a new feature is needed, a new issue should be opened and described in the issue like feature_request.md. But who is the team that decides whether this feature is approved? How and how often does the team decide?

I wonder if it would be better to explain all of this.

@ss892714028
Copy link
Contributor

/assign

@ss892714028
Copy link
Contributor

ss892714028 commented Mar 4, 2022

Thank you for the input. For the questions you have:

  1. If you find the issue urgent, you can comment on the issue and explain your reasoning in detail. Milvus committer will add the label if he sees fit.
  2. The team is basically the Milvus committers who are active contributors in the Milvus community. You can check out the membership ladder here: https://github.com/milvus-io/community/blob/master/community-membership.
    There is no set schedule for the review, it is done in an ad hoc basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants