From 4ec1eec7349b23914fbbdaa70a8fd886f5ab54a7 Mon Sep 17 00:00:00 2001 From: ChengZi Date: Wed, 3 Apr 2024 15:18:20 +0800 Subject: [PATCH] update starting milvus way in test workflow Signed-off-by: ChengZi --- .github/workflows/test.yml | 7 ++++--- README.md | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 2d6ce40..af29730 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -6,6 +6,7 @@ on: - "src/**" - "tests/**" - pyproject.toml + - .github/workflows/test.yml concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} @@ -36,8 +37,8 @@ jobs: - name: Run Milvus run: | - wget https://github.com/milvus-io/milvus/releases/download/v2.4.0-rc.1/milvus-standalone-docker-compose.yml -O docker-compose.yml - sudo docker compose up -d + wget https://raw.githubusercontent.com/milvus-io/milvus/master/scripts/standalone_embed.sh + bash standalone_embed.sh start sleep 5 echo "\nMilvus server started!" @@ -46,5 +47,5 @@ jobs: - name: Stop and Remove Milvus run: | - sudo docker compose down + bash standalone_embed.sh stop echo "\nMilvus server stopped and removed!" \ No newline at end of file diff --git a/README.md b/README.md index 69e706f..cc5b4bc 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ First, to start up a Milvus service, follow the ['Start Milvus'](https://milvus.io/docs/install_standalone-docker.md#Start-Milvus) instructions in the documentation. -Then, to use the `MilvusDocumentStore` in a Haystack pipeline" +Then, to use the `MilvusDocumentStore` in a Haystack pipeline ```python from haystack import Document