-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rock line at ~46 height on mountains #202
Comments
Not actually fixed. Also, there seems to be another line of rocks at 126 of height. 46/47 is the limit between tundra and tundra_highland in default/mapgen.lua. Those should have been redefined by the mapgen_config mod... The height of the new mountain tops is 80 (126 - 46 = 80)... coincidence? |
Yes. That's it. It is subtle and is only visible on escarpments.
…-------- Message d'origine --------
Le 2024-07-27 20 h 33, Lazerbeak12345 a écrit :
Is this the bug you're seeing?
[image.png (view on web)](https://github.com/user-attachments/assets/13e63049-dffa-4101-a77e-67a82bcfeae6)
It's much more subtle than I expected... but I do agree it's a problem.
—
Reply to this email directly, [view it on GitHub](#202 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFQHO6GUA6ZZX5DMZHR3DO3ZOQ36BAVCNFSM6AAAAABLJILZ4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGI4TKMBSGE).
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Here's my attempt to git bisect:
Commits, linked: |
the skipped commits in question involved adding |
Ok, so git bisect doesn't return the commits in order, but here's the diff that all of those introduce, compared to the main as it was before these https://github.com/minetest-whynot/whynot-game/compare/7519c8d583fdb7169d0e6d70891388c029b2496f..23f29158eefed12b7dc9eb561cd58b397c7a9e66 |
This is a very weird one. I printed all the biome registrations and I don't see anything around 46. The vertical blend is actually 30, and the mountain top layer starts at 80, so those numbers are not adding up.
According to the docs https://github.com/minetest/minetest/blob/master/doc/lua_api.md#biome-definition
And that seems set properly on the lower biome. I tried to change the vertical_blend to 10, and that didn't affect the height of the rock line. https://github.com/minetest/minetest_game/blob/master/mods/default/mapgen.lua#L977 |
It's not the ore stratum... changed them to no avail. Tried tweaking other settings without luck. |
At this point it's all I see :( There does seem to be something weird happening at block 46. |
Problem
There's a graphical anomaly showing rocks on the flank of mountains around ~46, and ~126 blocks height.
Steps to reproduce
Observe a tall mountain.
Expected behavior
Mountains should not have an artificial looking horizontal line.
Minetest client version
5.6.8
WhyNot? Game version
origin/main (git, not released)
Operating system/version
Ubuntu 22.04
Installation
Git
Additional mods enabled in your world (ex. technics, mobs_animals, etc.)
none
The text was updated successfully, but these errors were encountered: