Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain events queue config and irsa for Offender Categorisation API in preprod #29953

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

timothy-ness
Copy link
Contributor

No description provided.

@timothy-ness timothy-ness requested a review from a team as a code owner February 25, 2025 08:40
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 21 to be created, 0 to be destroyed, 1 to be updated, 0 to be replaced and 51 unchanged.

Resources to create:

+ aws_sns_topic_subscription.offender_categorisation_api_queue_for_domain_events_subscription_details
+ aws_sqs_queue_policy.offender_categorisation_api_queue_for_domain_events_queue_policy
+ kubernetes_secret.hmpps_domain_events_topic
+ kubernetes_secret.offender_categorisation_api_queue_for_domain_events
+ kubernetes_secret.offender_categorisation_api_queue_for_domain_events_dead_letter_queue
+ module.irsa_hmpps_offender_categorisation_api.kubernetes_service_account.generated_sa
+ module.irsa_hmpps_offender_categorisation_api.module.iam_assumable_role.aws_iam_role.this[0]
+ module.irsa_hmpps_offender_categorisation_api.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-domain-events-preprod/sns/cloud-platform-Digital-Prison-Services-15b2b4a6af7714848baeaf5f41c85fcd/irsa-policy-arn"]
+ module.irsa_hmpps_offender_categorisation_api.module.iam_assumable_role.aws_iam_role_policy_attachment.this["offender_categorisation_api_queue_for_domain_events"]
+ module.irsa_hmpps_offender_categorisation_api.module.iam_assumable_role.aws_iam_role_policy_attachment.this["offender_categorisation_api_queue_for_domain_events_dead_letter_queue"]
+ module.irsa_hmpps_offender_categorisation_api.random_id.id
+ module.offender_categorisation_api_queue_for_domain_events.aws_iam_policy.irsa
+ module.offender_categorisation_api_queue_for_domain_events.aws_kms_alias.alias[0]
+ module.offender_categorisation_api_queue_for_domain_events.aws_kms_key.kms[0]
+ module.offender_categorisation_api_queue_for_domain_events.aws_sqs_queue.terraform_queue
+ module.offender_categorisation_api_queue_for_domain_events.random_id.id
+ module.offender_categorisation_api_queue_for_domain_events_dead_letter_queue.aws_iam_policy.irsa
+ module.offender_categorisation_api_queue_for_domain_events_dead_letter_queue.aws_kms_alias.alias[0]
+ module.offender_categorisation_api_queue_for_domain_events_dead_letter_queue.aws_kms_key.kms[0]
+ module.offender_categorisation_api_queue_for_domain_events_dead_letter_queue.aws_sqs_queue.terraform_queue
+ module.offender_categorisation_api_queue_for_domain_events_dead_letter_queue.random_id.id

Resources to update:

! module.dps_rds.aws_db_parameter_group.custom_parameters

@sablumiah
Copy link
Contributor

This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team.
Reason:
🕵️‍♂️ Manual review required: OPA auto approve policy checks did not pass.
Please raise it in #ask-cloud-platform Slack channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants