Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Make context menus closer to the original #15

Open
filiph opened this issue Oct 17, 2023 · 6 comments
Open

Feat: Make context menus closer to the original #15

filiph opened this issue Oct 17, 2023 · 6 comments

Comments

@filiph
Copy link
Contributor

filiph commented Oct 17, 2023

I'd like to bring Menu95 closer to this:

win95desktop2

Note the blue mouse hover, the separator lines, the padding, the > arrow.

Not a high priority, but I thought I'd put this down somewhere, and this is the best place. I might get to this at some point myself.

@kelvinwieth
Copy link

Can I work on this?

@miquelbeltran
Copy link
Owner

@kelvinwieth you can work on this, but there is no ticket assignment, just send a PR when ready!

@vaibhavppandey
Copy link

@miquelbeltran if @kelvinwieth is not currently working on this, I would love to try this out

@kelvinwieth
Copy link

@miquelbeltran if @kelvinwieth is not currently working on this, I would love to try this out

Hey @vaibhavppandey, I'm working on this, but since there's no ticket assignment, idk how is the correct approach. All I can say is that I will probably open the PR until next sunday.

@vaibhavppandey
Copy link

@miquelbeltran if @kelvinwieth is not currently working on this, I would love to try this out

Hey @vaibhavppandey, I'm working on this, but since there's no ticket assignment, idk how is the correct approach. All I can say is that I will probably open the PR until next sunday.

Oh hey @kelvinwieth . My bad, I did not notice that this issue is not assigned to you. I am eager to contribute and since it is taking a bit longer, can I help or maybe we can work together? Let me know :)

@kelvinwieth
Copy link

kelvinwieth commented Nov 1, 2023

Oh hey @kelvinwieth . My bad, I did not notice that this issue is not assigned to you. I am eager to contribute and since it is taking a bit longer, can I help or maybe we can work together? Let me know :)

I'm not sure if I can finish this week, so you can work on this, @vaibhavppandey.

Also, here is some things I discovered:

  1. The easiest way to customize a menu style would be to wrap the PopupMenuEntry with a Theme, and change things like hoverColor;
  2. In our case, this is not possible because a Menu95 is displayed with the Flutter showMenu method, and therefore it cannot be wrapped by any widget;
  3. So, my guess is that we could change the api, and do something like Menu95(items).show(context) instead of showMenu95(items);
  4. I think this would be a decrease in the developer experience, and that's why I was exploring new ideas, including the usage of MenuAnchor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants