Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

would you like to incorporate the work with jasync-sql? #1

Closed
oshai opened this issue Mar 5, 2019 · 4 comments
Closed

would you like to incorporate the work with jasync-sql? #1

oshai opened this issue Mar 5, 2019 · 4 comments
Assignees

Comments

@oshai
Copy link

oshai commented Mar 5, 2019

Recently, there has been a request for jasync-sql to support r2dbc: jasync-sql/jasync-sql#98 . jasync-sql supports MySQL already and we're building a bridge to r2dbc.

Would you like to merge the efforts?

@mp911de
Copy link
Contributor

mp911de commented Mar 5, 2019

This is actually a pretty decent proposal. Having fully reactive components as core engine is of huge value because the core architecture dictates how capable an entire driver can be.

The core functionality can be either exposed through a reactive streaming API (emitting items one by one, flow control, backpressure) or a less capable API (e.g. working on CompletableFuture<List<Row>> or even CompletableFuture<ResultSet> level).

@mirromutth
Copy link
Owner

mirromutth commented Mar 7, 2019

Just like @mp911de said, this is actually a pretty decent proposal. I will try to get familiar with jasync-sql before I fork from and submit PR to jasync-sql. And I know Mauricio Linhares driver already has NOT been maintenanced (postgresql-async#250), which used by Vert.x frameworks (I haven't paid attention to Vert.x for a long time because of my work, it looks like the Vert.x framework is now more recommended to use jasync-sql).

One of my ideas is to provide this clean room implementation (mirromutth/r2dbc-mysql) without any mysql-connector-j code and structure, because mysql-connector-j licensed under GPLv2 license, and the R2DBC projects uses Apache 2.0 license, they are conflicting licenses.

@mirromutth mirromutth self-assigned this Mar 7, 2019
@oshai
Copy link
Author

oshai commented Mar 7, 2019

Great! I started a very initial implementation on this PR: jasync-sql/jasync-sql#99 . You're welcome to use it as a reference and continue from there.

@mirromutth
Copy link
Owner

I will continue to follow the r2dbc support on jasync-sql, this issue will be closed, see jasync-sql

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants