Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alist to dict handling in iOS 2.73 #3347

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

ewpatton
Copy link
Member

Change-Id: Ibc83e0aae5d5fb58c89591079cb8117a08c105b9

General items:

If your code changes how something works on the device (i.e., it affects the companion):

  • I branched from ucr
  • My pull request has ucr as the base

What does this PR accomplish?

This fixes an issue where a raw Scheme list that looks like a YailList but isn't a YailList is passed to the alistToDict method. This manifests as an error at the user level.

Fixes #3340

Change-Id: Ibc83e0aae5d5fb58c89591079cb8117a08c105b9
@ewpatton
Copy link
Member Author

@stezelMIT @SusanRatiLane I plan to put this onto TestFlight today.

@ewpatton ewpatton added this to the iOS 2.74 milestone Jan 22, 2025
@ewpatton ewpatton added the testflight This PR is deployed via Apple TestFlight label Jan 22, 2025
Copy link
Contributor

@SusanRatiLane SusanRatiLane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SusanRatiLane SusanRatiLane merged commit fbb7e1c into mit-cml:ucr Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS PICaboo started giving runtime error about YailList
2 participants