Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New folder dialog does not handle name validation correctly #3345

Open
1 of 8 tasks
SusanRatiLane opened this issue Jan 22, 2025 · 3 comments · May be fixed by #3362
Open
1 of 8 tasks

New folder dialog does not handle name validation correctly #3345

SusanRatiLane opened this issue Jan 22, 2025 · 3 comments · May be fixed by #3362

Comments

@SusanRatiLane
Copy link
Contributor

Describe the bug

The new folder wizard uses the project name validation methods and displays the related error messages. In addition to the error messages referencing "project" instead of "folder," they also don't correctly describe the wizard behavior. The folder wizard does not automatically remove or replace invalid characters, e.g. replacing " " with "_", and the error message says it will.

Affects

  • Designer
  • Blocks editor
  • Projects Explorer
  • Companion
  • Compiled apps
  • Buildserver
  • Debugging
  • Other... (please describe)

Expected behavior

Folder name validation should handle automatically handle invalid characters the same way project name validation does, and the strings referencing projects should be fixed.

Steps to reproduce

Click the new folder button on the project list and try some names.

@d1vyanshu-kumar
Copy link
Contributor

@SusanRatiLane If no one is currently working on this issue, could you please assign it to me?

@SusanRatiLane
Copy link
Contributor Author

@SusanRatiLane If no one is currently working on this issue, could you please assign it to me?

Done. Thanks for taking it on.

@d1vyanshu-kumar
Copy link
Contributor

Hi @SusanRatiLane,

I need your help with an issue I encountered.

Currently, when entering an invalid project name with spaces between letters, no alert message is triggered. However, for folder names, an alert does appear. The folder wizard does not replace spaces with underscores ("_"), unlike expected behaviour.

can you please verify this approach that I am on the right track or not?
Remove the alert for invalid folder names.
Instead of prompting the user to enter a valid folder name, automatically replace spaces with underscores if the user clicks "OK" with an invalid folder name, similar to the project configuration.
Let me know your thoughts. Thanks!

d1vyanshu-kumar added a commit to d1vyanshu-kumar/appinventor-sources that referenced this issue Feb 1, 2025
d1vyanshu-kumar added a commit to d1vyanshu-kumar/appinventor-sources that referenced this issue Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants