diff --git a/.clang-tidy b/.clang-tidy index 7efe855e6..b1aebb03c 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -10,7 +10,12 @@ Checks: ' -cppcoreguidelines-pro-bounds-array-to-pointer-decay, readability-*, google-explicit-constructor, - -readability-identifier-length' + -readability-identifier-length, + -cppcoreguidelines-avoid-const-or-ref-data-members, + -bugprone-unchecked-optional-access, + -cppcoreguidelines-avoid-do-while, + -modernize-use-emplace, + -readability-convert-member-functions-to-static' CheckOptions: - {key: cppcoreguidelines-explicit-virtual-functions.AllowOverrideAndFinal, value: true} - {key: modernize-use-override.AllowOverrideAndFinal, value: true} diff --git a/tests/integration/mock_system.cpp b/tests/integration/mock_system.cpp index 1e95eeecf..84b6c578e 100644 --- a/tests/integration/mock_system.cpp +++ b/tests/integration/mock_system.cpp @@ -31,29 +31,42 @@ namespace cbdc::test { const std::unordered_set& disabled_modules, config::options opts) : m_opts(std::move(opts)) { - m_module_endpoints.insert({mock_system_module::watchtower, - m_opts.m_watchtower_internal_endpoints}); + if(!m_opts.m_watchtower_internal_endpoints.empty()) { + m_module_endpoints.emplace(mock_system_module::watchtower, + m_opts.m_watchtower_internal_endpoints); + } + + if(!m_opts.m_atomizer_endpoints.empty()) { + m_module_endpoints.emplace(mock_system_module::atomizer, + m_opts.m_atomizer_endpoints); + } - m_module_endpoints.insert( - {mock_system_module::atomizer, m_opts.m_atomizer_endpoints}); + if(!m_opts.m_coordinator_endpoints.empty()) { + auto coord_eps = std::vector(); + for(const auto& node_eps : m_opts.m_coordinator_endpoints) { + coord_eps.insert(coord_eps.end(), + node_eps.begin(), + node_eps.end()); + } - auto coord_eps = std::vector(); - for(const auto& node_eps : m_opts.m_coordinator_endpoints) { - coord_eps.insert(coord_eps.end(), - node_eps.begin(), - node_eps.end()); + m_module_endpoints.emplace(mock_system_module::coordinator, + coord_eps); } - m_module_endpoints.insert( - {mock_system_module::coordinator, coord_eps}); - m_module_endpoints.insert( - {mock_system_module::archiver, m_opts.m_archiver_endpoints}); + if(!m_opts.m_archiver_endpoints.empty()) { + m_module_endpoints.emplace(mock_system_module::archiver, + m_opts.m_archiver_endpoints); + } - m_module_endpoints.insert( - {mock_system_module::shard, m_opts.m_shard_endpoints}); + if(!m_opts.m_shard_endpoints.empty()) { + m_module_endpoints.emplace(mock_system_module::shard, + m_opts.m_shard_endpoints); + } - m_module_endpoints.insert( - {mock_system_module::sentinel, m_opts.m_sentinel_endpoints}); + if(!m_opts.m_sentinel_endpoints.empty()) { + m_module_endpoints.emplace(mock_system_module::sentinel, + m_opts.m_sentinel_endpoints); + } for(const auto& m : disabled_modules) { m_module_endpoints.erase(m);