Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline banner not shown when app opened with no network. #3

Closed
HyzamAli opened this issue Jun 27, 2021 · 1 comment
Closed

Offline banner not shown when app opened with no network. #3

HyzamAli opened this issue Jun 27, 2021 · 1 comment

Comments

@HyzamAli
Copy link

To reproduce

  • Turn of wifi/cellular data
  • open application
  • offline banner not shown

This is because ConnectivityManager.NetworkCallback inside /food2forkcompose/presentation/util/ConnectionLiveData.kt gets triggered only when:

  • A network connection is present (overrides onAvailable())
  • A network is lost (overrides onLost())
    and not when network is unavailable by default
@mitchtabian
Copy link
Owner

I'm active here #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants