Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonLdView - JsonLdContext::build is brittle and needs refactoring #142

Open
cnizzardini opened this issue Jul 6, 2023 · 0 comments
Open

JsonLdView - JsonLdContext::build is brittle and needs refactoring #142

cnizzardini opened this issue Jul 6, 2023 · 0 comments
Labels
bug Something isn't working enhancement New feature or request
Milestone
v2.0.0

Comments

@cnizzardini
Copy link
Member

This method is currently locating an Entity by string, inflection and direct instantiation of the table instance. This seems fraught with problems. Instead, the method should take a table alias string, use the TableLocator class, and then pass that into the ModelDecorator.
@cnizzardini cnizzardini added bug Something isn't working enhancement New feature or request labels Jul 6, 2023
@cnizzardini cnizzardini added this to the v2.0.0 milestone Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@cnizzardini