Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs Updates - Errors when including without mjml & body tags #11

Closed
CyberPunkCodes opened this issue Nov 12, 2018 · 1 comment
Closed

Comments

@CyberPunkCodes
Copy link

As one person already said in #9 , this needs updated to the latest MJML version.

This also is throwing errors on a project I created with the latest MJML app.

My main template includes other template files, such as header.

<mjml>
  <mj-head>
  </mj-head>
  <mj-body>
    <mj-include path="./header.mjml" />
    <mj-include path="./content.mjml" />
    <mj-include path="./footer.mjml" />
  </mj-body>
</mjml>

And the included file example for say header.mjml:

<mj-section>
  <mj-column>
    <mj-text>
      The Header Here
    </mj-text>
  </mj-column>
</mj-section>

Throws a linter error complaining about missing the <mjml> and <mj-body> tags.

@iRyusa
Copy link
Member

iRyusa commented Nov 13, 2018

Well, we did that in the past, but it was a messy move from us.

Now in MJML4, we can validate included files and show errors where you includes it, so the context of include can throw errors / or not depending of how you're using it.

But as #9 said, we should update this package to MJML4 now 👍

@iRyusa iRyusa closed this as completed Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants