Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist #2

Open
zoonderkins opened this issue May 30, 2019 · 13 comments
Open

Whitelist #2

zoonderkins opened this issue May 30, 2019 · 13 comments

Comments

@zoonderkins
Copy link

www.freedownloadmanager.org
pbs.twimg.com

mkb2091 added a commit that referenced this issue May 30, 2019
@mkb2091
Copy link
Owner

mkb2091 commented May 30, 2019

Thanks for spotting the false positive, I've added them to the whitelist

@mkb2091 mkb2091 closed this as completed May 30, 2019
@mkb2091 mkb2091 reopened this May 30, 2019
@mkb2091
Copy link
Owner

mkb2091 commented May 30, 2019

I'll keep this issue open for future false positives

@mkb2091
Copy link
Owner

mkb2091 commented May 30, 2019

I found files.freedownloadmanager.org, and files2.freedownloadmanager.org are blocked, I'm assuming they are needed so I'll also add them to the whitelist

@zoonderkins
Copy link
Author

@mkb2091
Copy link
Owner

mkb2091 commented Jun 15, 2019

I am already using the second one, and didn't know about the first. I'll add it now

@mkb2091
Copy link
Owner

mkb2091 commented Jun 15, 2019

I just checked, and the first one is under a CC BY-NC 4.0 license, which isn't compatible with GPLv3, so at the moment I can't add it

@zoonderkins
Copy link
Author

I just checked, and the first one is under a CC BY-NC 4.0 license, which isn't compatible with GPLv3, so at the moment I can't add it

First whitelist is maintain by me, so you can add into ur project.
Second question, why CC BY-NC4.0 doesn't compatible with GPLv3?
Im using this license is to prevent from someone selling my whitelist without noticing me

@mkb2091
Copy link
Owner

mkb2091 commented Jun 15, 2019

CC BY-NC4.0 prevents anyone from selling the list, and any copys of the list must also have that license. GPLv3 allows selling, just requires that anyone who receives the list(or a product with the list built in), must have the same freedom.

mkb2091 added a commit that referenced this issue Jun 15, 2019
It was also added to .gitignore to ensure there isn't a copy of the whitelist
in the repository
@mkb2091
Copy link
Owner

mkb2091 commented Jun 15, 2019

Thanks for giving permission to use the whitelist, I've added it, but also added the temp files to .gitignore, so anyone who wants to use your list will have to download it from your github repo

mkb2091 added a commit that referenced this issue Jun 15, 2019
@zoonderkins
Copy link
Author

www.namecheap.com is blocked

mkb2091 added a commit that referenced this issue Jul 3, 2019
@mkb2091
Copy link
Owner

mkb2091 commented Jul 3, 2019

Thanks for spotting it, previously only namecheap.com had been in a whitelist

@lightswitch05
Copy link
Contributor

If you ever have issues with one of my lists, please report it directly to me so that we can have a discussions about why I blocked it and if it should remain blocked or not.

@mkb2091
Copy link
Owner

mkb2091 commented Jul 5, 2019

Yeah, fair enough. I'll try to get in touch with any list maintainers when I add a domain in their list to the whitelist

mkb2091 added a commit that referenced this issue Oct 15, 2019
mkb2091 added a commit that referenced this issue Oct 15, 2019
It was also added to .gitignore to ensure there isn't a copy of the whitelist
in the repository
mkb2091 added a commit that referenced this issue Oct 15, 2019
mkb2091 added a commit that referenced this issue Oct 15, 2019
mkb2091 added a commit that referenced this issue Aug 12, 2021
mkb2091 added a commit that referenced this issue Aug 12, 2021
It was also added to .gitignore to ensure there isn't a copy of the whitelist
in the repository
mkb2091 added a commit that referenced this issue Aug 12, 2021
mkb2091 added a commit that referenced this issue Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants