You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Deadbolt does support multiple deadbolt route modifier tags for one route, which all have to pass to process the route (meaning it's AND and ignores the deadbolt.java.constraint-mode config). See #96.
We might want to implement an OR mode as well.
However that should be a different config than deadbolt.java.constraint-mode because
before using route modifier tags we were using comments and back than only one comment was allowed (meaning there was no AND mode back then as well of course). Therefore we also don't need
something like PROCESS_FIRST_CONSTRAINT_ONLY but only AND and OR.
to be able to control annotations and filter differently. Maybe someone want's to OR the filter constraints but AND the annotation constraints.
Same here, we could add AND and OR mode. Right now you can not even add multiple constraints for one route...
What needs to be done is:
In AuthorizedRoute change the constraint field to be a List:
privatefinalList<FilterFunction> constraints;
and maybe even add a mode field to be even able to set a different mode for each route:
privatefinalModemode;
and of course add a mode config in reference.conf which defines the default for all routes. (Maybe share/use the same config like DeadboltRouteModifierTagsFilter above uses?)
The text was updated successfully, but these errors were encountered:
For
DeadboltRouteModifierTagsFilter
Deadbolt does support multiple deadbolt route modifier tags for one route, which all have to pass to process the route (meaning it's
AND
and ignores thedeadbolt.java.constraint-mode
config). See #96.We might want to implement an
OR
mode as well.However that should be a different config than
deadbolt.java.constraint-mode
becauseAND
mode back then as well of course). Therefore we also don't needsomething like
PROCESS_FIRST_CONSTRAINT_ONLY
but onlyAND
andOR
.OR
the filter constraints butAND
the annotation constraints.For
DeadboltRoutePathFilter
Same here, we could add
AND
andOR
mode. Right now you can not even add multiple constraints for one route...What needs to be done is:
In
AuthorizedRoute
change theconstraint
field to be aList
:and maybe even add a
mode
field to be even able to set a different mode for each route:and of course add a mode config in
reference.conf
which defines the default for all routes. (Maybe share/use the same config likeDeadboltRouteModifierTagsFilter
above uses?)The text was updated successfully, but these errors were encountered: