Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Dirac Initialization Method #1505

Open
Saanidhyavats opened this issue Oct 19, 2024 · 3 comments
Open

Implementation of Dirac Initialization Method #1505

Saanidhyavats opened this issue Oct 19, 2024 · 3 comments

Comments

@Saanidhyavats
Copy link
Contributor

I was thinking to add https://pytorch.org/docs/stable/_modules/torch/nn/init.html#dirac_ initialization method. It can be a useful feature for MLX.

@Saanidhyavats
Copy link
Contributor Author

What do you think about it @awni ?

@awni
Copy link
Member

awni commented Oct 22, 2024

It's a bit niche.. so I'm not sure it's worth adding. I see that it's in PyTorch..but I also don't know who uses that anymore. What we can do is leave the issue open.. and if it gets attention we can consider adding it reactively. I think it's better than adding code that will never / rarely be used.

@Saanidhyavats
Copy link
Contributor Author

Okay, sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants