Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip eval on train and test for self-reporting results #725

Open
Niccolo-Ajroldi opened this issue Mar 26, 2024 · 2 comments
Open

Skip eval on train and test for self-reporting results #725

Niccolo-Ajroldi opened this issue Mar 26, 2024 · 2 comments
Labels
✨ Feature Request Request for a new feature or enhancement of an existing one Good First Issue

Comments

@Niccolo-Ajroldi
Copy link
Contributor

Niccolo-Ajroldi commented Mar 26, 2024

Feature request: allow users to skip eval on train and test

Evaluating on the training and test sets is time-consuming and not necessary for self-reporting results.
We should add a flag that allow the user to skip eval on these datasets, to make scoring faster.

Accordingly, in this scenario we should modify:

goals_reached = (
              train_state['validation_goal_reached'] and
              train_state['test_goal_reached'])

into:

goals_reached = (train_state['validation_goal_reached'])

This would speed up self-evalution even more, by stopping training when validation target is reached, avoiding unnecessary usage of computational resources.

@priyakasimbeg
Copy link
Contributor

priyakasimbeg commented Mar 29, 2024

You're right this is a good suggestion to allow to skip on train and test splits.

@priyakasimbeg priyakasimbeg added the ✨ Feature Request Request for a new feature or enhancement of an existing one label Mar 29, 2024
@fsschneider
Copy link
Contributor

We plan to discuss feature requests like these in the benchmark code during the WG meeting on Thursday, 9/5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature Request Request for a new feature or enhancement of an existing one Good First Issue
Projects
None yet
Development

No branches or pull requests

3 participants