-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group semantics regression on FLORES 200 #295
Comments
@mkuchnik Thanks for opening the bug. I expected https://github.com/mlcommons/croissant/blob/main/datasets/recipes/output/translations_from_zip.jsonl to cover this test case (extract the filename for each line), but apparently there is a difference. I can come up with a better implementation for tomorrow. |
Tests that FLORES 200 is loading records correctly by comparing against a ground truth of 10 records. While the test is not exhaustive, checking the first 10 records can prevent regressions like #295 in many cases.
This allows to have all fields computed at the same place. For example, this avoids repeating computation to compute separately lines and lineNumbers. Now, all fields are in the same ReadFields.__call__ function. Fixes: #295
This allows to have all fields computed at the same place. For example, this avoids repeating computation to compute separately lines and lineNumbers. Now, all fields are in the same ReadFields.__call__ function. Fixes: #295
This allows to have all fields computed at the same place. For example, this avoids repeating computation to compute separately lines and lineNumbers. Now, all fields are in the same ReadFields.__call__ function. Fixes: #295
This allows to have all fields computed at the same place. For example, this avoids repeating computation to compute separately lines and lineNumbers. Now, all fields are in the same ReadFields.__call__ function. Fixes: #295
@mkuchnik Do you confirm that PR #309 fixes this issue?
|
@marcenacp Looks good to me! Seems a bit faster, too. |
…elds. (#309) This allows to have all fields computed at the same place. For example, this avoids repeating computation to compute separately lines and lineNumbers. Now, all fields are in the same `ReadFields.__call__` function. Fixes: #295 Note for reviewers: the main commit is the first commit of the chain. Then we remove code, rename, comment and test.
FLORES 200 was working on 0c66893 but it is different on main (487ec5c).
Repro from recipes directory:
Before the test set was added (causing the record_set to be renamed), the call would be:
Note: this can block for a long time in the correct case, so it may be better to print iteratively to see if count goes over 997.
The length should be 204 * 997, but it is only 997. This is because the data from each of the 204
.dev
files have been collapsed at some point. Instead of each of the files yielding 997 rows, the effect is 997 samples and some of the columns are None.The text was updated successfully, but these errors were encountered: