HELP-Med show questions #295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
shincap8
reviewed
Aug 15, 2024
| @@ -330,7 +330,9 @@ const ChatWithInstructions: FC< | |||
| <div className="flex items-end justify-end gap-4"> | |||
| <GeneralButton | |||
| text="I understand" | |||
| onClick={() => setReadInstructions(true)} | |||
| onClick={() => {setReadInstructions(true); | |||
| setIsGenerativeContext(false);} | |||
There was a problem hiding this comment.
If an user hasn't click on save and then finish, and clicks on the submit button at the end of the page the interaction with the bot wouldn't be properly saved. Please remove line 334
|
Good point. The other changes aren't useful without line 334, so I'll just cancel this PR. It would be nice to be able to show the questions right away because some users keep trying to put their answers in the chatbots, but changing the "Submit" button seems like a bad idea right now, so I'll keep it as is. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the questions appear as soon as the instructions have been read. This uses a Boolean that seems to be misnamed. For some reason, whether or not the questions appear is controlled by
isGenerativeContext. To avoid breaking anything else, I have kept the name as it is, but this seems like something that should be refactored eventually.