You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using the wrap: true option results in the module being wrapped in
(function(angular, undefined) {
...
})(angular);
Passing undefined as an argument conflicts with best practices and the no-shadow-restricted-names rule in ESLint. This should not be the default behavior of wrap: true in my opinion.
In generell I would not recommend to lint auto generated files, but this is another story.
What you do is the way to go, for everything that does not fit your needs.
Changing the wrapper could lead to other problems for other users. If I will release a version 3 of this task I would totally agree this is the way to go.
Using the
wrap: true
option results in the module being wrapped inPassing
undefined
as an argument conflicts with best practices and theno-shadow-restricted-names
rule in ESLint. This should not be the default behavior ofwrap: true
in my opinion.https://eslint.org/docs/rules/no-shadow-restricted-names
A workaround for now is defining my own wrap function.
The text was updated successfully, but these errors were encountered: