Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor repo: partial affine transform #6

Open
opatiny opened this issue Jun 21, 2023 · 0 comments
Open

Refactor repo: partial affine transform #6

opatiny opened this issue Jun 21, 2023 · 0 comments
Assignees

Comments

@opatiny
Copy link
Contributor

opatiny commented Jun 21, 2023

What we currently implemented in this repo is not the full affine transform (2 degrees of freedom -> allows warping and reflection), but the partial affine transform (only scaling, translation and rotation).

I would rename all functions and objects currently used to include the keyword partial so that we can reuse the current function names for the actual full affine transform. This will however be a breaking change.

@opatiny opatiny self-assigned this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant