Several changes detailed below #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 13, 2023 06:07
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 96.00% 99.29% +3.29%
==========================================
Files 12 12
Lines 700 711 +11
Branches 98 101 +3
==========================================
+ Hits 672 706 +34
+ Misses 28 5 -23
☔ View full report in Codecov by Sentry. |
ghost
marked this pull request as ready for review
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
refactor: remove repetition by refactoring all solvers into a single function
fix: do not iterate if data is empty
fix: deprecate
fcnnlsVectorand updatefcnnlsto handle 1DArrays (this also fixes another bug sincenumber[]is actually not accepted in the previous version.)chore: fix benchmark
chore: readme examples and explanations.
close #22
close #24