Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Bagging Options #18

Open
micha-lmxt opened this issue Oct 12, 2020 · 1 comment
Open

Feature Bagging Options #18

micha-lmxt opened this issue Oct 12, 2020 · 1 comment

Comments

@micha-lmxt
Copy link
Contributor

Hi,

thank you for your work on this library.

Other implementations of random forests apply feature bagging at every split during tree generation. So I think it would be better to implement it at the CART level, not here.

Also, "replacement" is a bit of weird option, since it makes no sense to supply a feature more than once to the tree generation. Thus, it basically just randomly shrinks the number of features used for a tree.

@lpatiny
Copy link
Member

lpatiny commented Oct 15, 2020

Thanks for your contributions. Please could you fix the test cases that are currently failing ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants