Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconsider default values #16

Open
targos opened this issue Nov 19, 2015 · 3 comments
Open

reconsider default values #16

targos opened this issue Nov 19, 2015 · 3 comments
Assignees
Milestone

Comments

@targos
Copy link
Member

targos commented Nov 19, 2015

Current default values are not intuitive. The SG function is first a smoothing algorithm and should behave like this if the derivative option is not entered.
See #15

@targos targos added this to the v3.0.0 milestone Nov 19, 2015
@maasencioh
Copy link
Member

@targos , you are right, it's a smoothing algorithm, but the usual application is for derivatives

@maasencioh
Copy link
Member

@mljs/collaborators what should we do with this?, I think that the default value should be the first derivative.

@maasencioh maasencioh self-assigned this Feb 19, 2016
@andcastillo
Copy link

The default value should be 0. In principle it is intended to smooth the function, but S-G extended it to approach derivatives as well. I don't think there is a preferred derivative order. It will depend on the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants