-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded swipe to support from: -> to: #2117
base: main
Are you sure you want to change the base?
Conversation
Thanks @NorseGaud! This looks really handy! You could certainly do an integration test, and perhaps some of the maths is unit testable? I don't know if there's a suitable place for an e2e test (i.e. I don't know if there's a suitable element to swipe on to see an effect to test against). Lemme know if you need a hand! |
Hey @Fishbowler I found the docs for testing. I spent a few hours trying to get an IntegrationTest, but failed to do so. it seems like
Can you recommend the approach I can take for this? Also, apologies but my developer wrote all of this new code and I can't afford to have him write tests too. I'm just not good enough at Kotlin to understand how to get this test written :( |
You can swipe from element id to the point using relative | absolute coordinates.
01c7c91
to
3fa3a9e
Compare
This looks like an awesome and really helpful PR. Does anyone know when this will be released? |
Hi @c-goettert the only thing left is to add the proper tests that the maestro team wants. Unfortunately I don't have any more money for this project to have my dev do it, since we're unblocked in our fork of the code, so I can't do it. Maybe you could help? |
Proposed changes
In #1203, we realized all I needed to do was expand swipe a bit to support swiping on a picker wheel. Here is an example video showing how it works.
maestro-swipe++.mov
(we're writing a test suite for https://memlane.app)
This change adds
to:
forfrom:
definitions, allowing users to be a bit more precise (move a wheel picker by 1) sincedirection
is far too much of a swipe for my needs.Testing
See video. Can devs recommend where we should add tests for this?
Documentation
mobile-dev-inc/maestro-docs#97