chore: add e2e tests for optional #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishbowler
reviewed
Oct 8, 2024
Fishbowler
approved these changes
Oct 22, 2024
Fishbowler
force-pushed
the
update-e2e-test-optional
branch
from
4c4c640 to
8863ee6
Compare
|
Rebased. |
Fishbowler
force-pushed
the
update-e2e-test-optional
branch
from
8863ee6 to
eea704c
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 issues with optional commands, this PR creates tests for the issues:
The optional flag on the selector was removed that broke deserialization and the change was not backward compatible. The optional flag on the selector was removed from the test itself which prevented catching this regression. After observing this issue, the optional flag from selector is now deprecated.
Optional flags now throw command skipped exception. This was handled for the commands present in main flow but was missing in composite commands like runFlow. The addition to subFlow is suppose to catch those problem.