Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MA 2747] Check keyboard existence in all foreground apps #2184

Merged
merged 2 commits into from
Dec 12, 2024
Merged

[MA 2747] Check keyboard existence in all foreground apps #2184

merged 2 commits into from
Dec 12, 2024

Conversation

amanjeetsingh150
Copy link
Collaborator

Proposed changes

This PR fixes 2 things:

  1. Checks existence of keyboard in all the foreground apps instead of just first one.
  2. Use running apps + installed apps to get the installed apps.

Testing

Issues fixed

@linear Linear
Copy link

linear bot commented Dec 11, 2024

MA-2747 Incorrect failure for keyboard not present

@github-actions GitHub Actions
Copy link

Make sure to run ./maestro-ios-xctest-runner/build-maestro-ios-runner.sh with every swift change

amanjeetsingh150
amanjeetsingh150 commented Dec 11, 2024
View reviewed changes
maestro-ios-driver/src/main/kotlin/util/XCRunnerCLIUtils.kt
@@ -44,7 +44,7 @@ object XCRunnerCLIUtils {
val mapper = jacksonObjectMapper()
val appsMap = mapper.readValue(json, Map::class.java) as Map<String, Any>

return appsMap.keys
return appsMap.keys + runningApps(deviceId).keys
Copy link
Collaborator Author

@amanjeetsingh150 amanjeetsingh150 Dec 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Included the runningApps as well since appsMap was not giving all the list of installed apps.

Includes runningApp as well to make sure we include any system app not in appsMap

herval
herval approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@herval herval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Candidate for Fix of the Year 🏆

@amanjeetsingh150 amanjeetsingh150 merged commit 9165c50 into main Dec 12, 2024
9 checks passed
@amanjeetsingh150 amanjeetsingh150 deleted the MA-2747 branch December 12, 2024 07:07
@DavidREntwistle
Copy link

DavidREntwistle commented Dec 13, 2024 •
edited
Loading

We seem to be experiencing the Keyboard not presented within 1 second timeout for input command error in the latest 1.39.4 release. We perform two commands, first we tapOn the input field and then we perform the inputText.

The previous 1.39.2, didn't hit this if !isKeyboardPresented error, with the keyboard displaying for both the tapOn input field and inputText. Is there a reason why this might now be causing this following this change? @amanjeetsingh150

@DavidREntwistle DavidREntwistle mentioned this pull request Dec 13, 2024
Closed
1 task
amanjeetsingh150 added a commit that referenced this pull request Dec 30, 2024
@amanjeetsingh150
Revert "[MA 2747] Check keyboard existence in all foreground apps (#2184
6b93af7 
)"

This reverts commit 9165c50.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herval herval herval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amanjeetsingh150 @DavidREntwistle @herval