🛠️ Repo: Unify caught errors as err

[wnghdcjfe]

Feature Request Checklist

• I have read and agree to Mocha's Code of Conduct and Contributing Guidelines
• I have searched for related issues and issues with the faq label, but none matched my issue.
• I want to provide a PR to resolve this

Overview

Sometimes the error is written as e, sometimes as err. Why don't we unify it as err?

      try {
        foundReporter = require.resolve(reporterName);
        reporter = require(foundReporter);
      } catch (err) {
        if (foundReporter) {
          throw createInvalidReporterError(err.message, foundReporter);
        }
        // Try to load reporters from a cwd-relative path
        try {
          reporter = require(path.resolve(reporterName));
        } catch (e) {
          throw createInvalidReporterError(e.message, reporterName);
        }
      }

Suggested Solution

      try {
        foundReporter = require.resolve(reporterName);
        reporter = require(foundReporter);
      } catch (err) {
        if (foundReporter) {
          throw createInvalidReporterError(err.message, foundReporter);
        }
        // Try to load reporters from a cwd-relative path
        try {
          reporter = require(path.resolve(reporterName));
        } catch (err) {
          throw createInvalidReporterError(err.message, reporterName);
        }
      }

Alternatives

.

Additional Info

.

[JoshuaKGoldberg]

Hmm, this is a repository tooling request, not so much a feature request.

👍 from me on picking a name and sticking with it. As to which name... I personally prefer full names like error over abbreviations like err or e. But that's just me. @mochajs/maintenance-crew might have an opinion here.

[JoshuaKGoldberg]

Ok just following up: nobody from the crew has input and as you noted @wnghdcjfe, the existing standard is err. So 👍 from me on just unifying on err.